Fix the diff change detection #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem ------- Currently the diff change detection is broken because it fails when the changes are empty. Solution -------- 1. Fix the logic. 2. Include the file names in the error message. 3. Run diff
eed3si9n
force-pushed
the
wip/error_message
branch
from
1fdbc9c to
63928f2
Compare
ckipp01
approved these changes
Jan 7, 2023
Collaborator
ckipp01
left a comment
ckipp01
left a comment
There was a problem hiding this comment.
Thanks for fixing this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #85
Ref #94
Problem
Currently the diff change detection is broken because it fails
when the changes are empty.
Solution