Skip to content

Literal types #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ckipp01 merged 2 commits into from
Jan 7, 2023
Merged

Literal types #88

ckipp01 merged 2 commits into from
Jan 7, 2023

Conversation

@keynmol
Copy link
Collaborator

@keynmol keynmol commented Jan 6, 2023 •
edited
Loading

I had to separate null and non null because the former cannot be a literal type
image

Closes #84

eed3si9n
eed3si9n approved these changes Jan 6, 2023
View reviewed changes
Copy link
Collaborator

@eed3si9n eed3si9n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @keynmol!

@ckipp01
Copy link
Collaborator

ckipp01 commented Jan 7, 2023 •
edited
Loading

Since #91 fails since it doesn't regenerate the parser there I'm just going to piggy back on your PR here @keynmol. I went ahead and rebased, and then added another commit bumping the percentages.

Well that failed... I undid that commit but still kept the rebase. I'll get this back 🟢 and merge. Sorry to try and hijack your pr 😬 .

@ckipp01 ckipp01 merged commit 1cf780f into tree-sitter:master Jan 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eed3si9n eed3si9n eed3si9n approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Literal types

3 participants

@keynmol @ckipp01 @eed3si9n