Test on macOS/Windows only on C changes #86
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
force-pushed
the
wip/generate_check
branch
9 times, most recently
from
699358b to
48ea8a5
Compare
This was referenced Jan 6, 2023
Collaborator
|
Ugh, MacOS is upwards of 11 minutes now :( This makes none of the original idea feasible. |
eed3si9n
force-pushed
the
wip/generate_check
branch
from
48ea8a5 to
936f685
Compare
eed3si9n
changed the title
eed3si9n
force-pushed
the
wip/generate_check
branch
2 times, most recently
from
642ef28 to
66e38f3
Compare
Problem ------- Currently code is generated only for Linux. Also the parser check prevents us from omitting codegen in PR. Solution -------- 1. Run test on macOS and Windows only if the PR contains C code changes. 2. Run the parser check only if the PR contains C code changes
eed3si9n
force-pushed
the
wip/generate_check
branch
from
66e38f3 to
95c1437
Compare
Collaborator
Author
|
Going to self-merge to unblock open PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently code is generated only for Linux.
Also the parser check prevents us from omitting codegen in PR.
Solution