Fixes buffer overrun #160
Merged
Fixes buffer overrun #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eed3si9n
force-pushed
the
wip/buffer
branch
3 times, most recently
from
1e2596e to
55e6826
Compare
Problem ------- The buffer given for payload serialization is 1024, but we are currently using (1024 + 3) * sizeof(int) Solution -------- Reduce it way down, and fix a few things around unsigned vs int
This is useful in detecting and reproducing SEGV errors, but even after attempting to fix the issue, fuzz seems to fail in a different way, so at this point we can't turn this on for CI. This should create a workflow so we can manually trigger it.
ckipp01
approved these changes
Jan 17, 2023
Collaborator
ckipp01
left a comment
ckipp01
left a comment
There was a problem hiding this comment.
👍🏼 let's hope this gets rid of the pesky crashes.
Collaborator
|
@keynmol I'm going to just merge and try to update nvim-treesitter right away since people are hitting on this. Please do still take a gander at this though and we can adjust if necessary. |
ckipp01
added a commit
to ckipp01/nvim-treesitter
that referenced
this pull request
Jan 17, 2023
I just missed the cron to generate this by like an hour, so I'm just manually shooting this in. This should help in the crashes reported in nvim-treesitter#4170 since it includes tree-sitter/tree-sitter-scala#160.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #159
Ref nvim-treesitter/nvim-treesitter#4170
Problem
The buffer given for payload serialization is 1024, but we are currently using (1024 + 3) * sizeof(int)
Solution
Reduce it way down.