Include operator-like identifier as simple expression #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynmol
reviewed
Jan 9, 2023
script/smoke_test.sh
Outdated
| SCALA_SCALA_LIBRARY_EXPECTED=98 | ||
| SCALA_SCALA_COMPILER_EXPECTED=63 | ||
| DOTTY_COMPILER_EXPECTED=63 | ||
| DOTTY_COMPILER_EXPECTED=70 |
Problem ------- Currently operator-like identifiers are not part of the simple expression, so you can't call `::(123)`. Solution -------- This includes `$.operator_identifier` into `_simple_expression`, and further improves the expression hierarchy. Note that this removes test on double-prefix-expression. It's not allowed in Scala spec to have double-prefix.
eed3si9n
force-pushed
the
wip/call_expression
branch
from
905417e to
bf4102c
Compare
Merged
ckipp01
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Currently operator-like identifiers are not part of the simple expression, so you can't call
::(123).Solution
This includes
$.operator_identifierinto_simple_expression, and further improves the expression hierarchy.Note that this removes test on double-prefix-expression. It's not allowed in Scala spec to have double-prefix.