Sync and improve highlighting queries, add Scala 3 specific constructs and tests #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynmol
commented
Jan 8, 2023
| @@ -0,0 +1,37 @@ | |||
| object Hello { | |||
Collaborator
Author
There was a problem hiding this comment.
Tree sitter has builtin support for unit testing highlight rules: https://tree-sitter.github.io/tree-sitter/syntax-highlighting#unit-testing
eed3si9n
approved these changes
Jan 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #98
The highlighting queries in this repo are out of date with the version in nvim-treesitter: https://github.com/nvim-treesitter/nvim-treesitter/blob/master/queries/scala/highlights.scm
That version has some issues, so I used it as the bases and moved/simplified/added rules.
In particular we are more precise about highlighting identifiers (before they would be aggressively highlighted as variable in lots of places)
plans
I feel like we should grow the test coverage of highlighting queries, and once we're satisfied - upstream the changes
using these queries
The difference are subtle (and some identifiers have the correct highlighting only because they're capitalised), but in particular class/enum parameters and trait/class/object/enum names are treated correctly.
nvim-treesitter version
this version
