Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(scanner): formatting improvements #242

Merged
merged 2 commits into from
Feb 11, 2024
Merged

chore(scanner): formatting improvements #242

merged 2 commits into from
Feb 11, 2024

Conversation

ObserverOfTime
Copy link
Member

  • Add space after type casts and sizeof
  • RAW_STRING_DELIMITER_MAX -> MAX_DELIMITER_LENGTH (more intuitive?)
  • Remove the scan function and inline its contents
  • Replace _Static_assert with static_assert
    • Provided by assert.h since C11
    • Manually defined as assert otherwise
  • Some minor nitpicks

@amaanq
Copy link
Member

amaanq commented Feb 10, 2024

most of it looks good though I do prefer casts without a space in between (and with parenthesis) 😅

@ObserverOfTime
Copy link
Member Author

Casts or sizeof?

@amaanq
Copy link
Member

amaanq commented Feb 10, 2024

both, sorry for not being clear

@amaanq amaanq merged commit ef61cb5 into tree-sitter:master Feb 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants