Skip to content

fix: fix MSYS2 GCC build #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: fix MSYS2 GCC build #340

wants to merge 1 commit into from

Conversation

claritystorm
Copy link

No description provided.

@ObserverOfTime
Copy link
Member

MSYS2 GCC should be using the GCC flags. Is the build actually failing?

@claritystorm
Copy link
Author

claritystorm commented Mar 26, 2025 •
edited
Loading

Yes, as no wheel is provided and system() returns Windows on MSYS2 causing setup.py to pass invalid flags to GCC.

@claritystorm claritystorm mentioned this pull request Mar 26, 2025
Merged
@ObserverOfTime ObserverOfTime mentioned this pull request May 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@claritystorm @ObserverOfTime