Drop ancient EOL Node and Electron versions

tree-sitter · Dec 28, 2023 · 44bd12a · 44bd12a
1 parent 0e420cc
commit 44bd12a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 6 deletions.
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -12,8 +12,8 @@ on:
       - released
 
 env:
-  NODE_PREBUILD_CMD: npx prebuild -t 10.0.0 -t 12.0.0 -t 14.0.0 -t 16.0.0 -t 18.0.0 -t 20.0.0 --strip -u ${{ secrets.GH_TOKEN }}
-  ELECTRON_PREBUILD_CMD: npx prebuild -r electron -t 3.0.0 -t 4.0.0 -t 5.0.0 -t 6.0.0 -t 7.0.0 -t 8.0.0 -t 9.0.0 -t 10.0.0 -t 11.0.0 -t 12.0.0 -t 13.0.0 -t 14.0.0 -t 15.0.0 -t 16.0.0 -t 17.0.0 -t 18.0.0 -t 19.0.0 -t 20.0.0 -t 21.0.0 -t 22.0.0 -t 23.0.0 -t 24.0.0 -t 25.0.0 --strip -u ${{ secrets.GH_TOKEN }}
+  NODE_PREBUILD_CMD: npx prebuild -t 14.0.0 -t 16.0.0 -t 18.0.0 -t 20.0.0 --strip -u ${{ secrets.GH_TOKEN }}
+  ELECTRON_PREBUILD_CMD: npx prebuild -r electron -t 12.0.0 -t 13.0.0 -t 14.0.0 -t 15.0.0 -t 16.0.0 -t 17.0.0 -t 18.0.0 -t 19.0.0 -t 20.0.0 -t 21.0.0 -t 22.0.0 -t 23.0.0 -t 24.0.0 -t 25.0.0 --strip -u ${{ secrets.GH_TOKEN }}
 
 jobs:
 
@@ -25,8 +25,6 @@ jobs:
           - macos-latest
           - ubuntu-latest
         node:
-          - 10
-          - 12
           - 14
           - 16
           - 18

diff --git a/src/conversions.cc b/src/conversions.cc
@@ -23,7 +23,7 @@ void InitConversions(Local<Object> exports, Local<External> data_ext) {
   data->end_position_key.Reset(Nan::Persistent<String>(Nan::New("endPosition").ToLocalChecked()));
 
   auto js_point_transfer_buffer = ArrayBuffer::New(Isolate::GetCurrent(), 2 * sizeof(uint32_t));
-  data->point_transfer_buffer = (uint32_t *)(js_point_transfer_buffer->Data());
+  data->point_transfer_buffer = (uint32_t *)(js_point_transfer_buffer->GetBackingStore()->Data());
 
   Nan::Set(exports, Nan::New("pointTransferArray").ToLocalChecked(), Uint32Array::New(js_point_transfer_buffer, 0, 2));
 }

diff --git a/src/node.cc b/src/node.cc
@@ -22,7 +22,7 @@ static inline void setup_transfer_buffer(AddonData* data, uint32_t node_count) {
     data->transfer_buffer_length = new_length;
 
     auto js_transfer_buffer = ArrayBuffer::New(Isolate::GetCurrent(), data->transfer_buffer_length * sizeof(uint32_t));
-    data->transfer_buffer = (uint32_t *)(js_transfer_buffer->Data());
+    data->transfer_buffer = (uint32_t *)(js_transfer_buffer->GetBackingStore()->Data());
 
     Nan::Set(
       Nan::New(data->module_exports),