Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct go bindings #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ribru17
Copy link

@ribru17 ribru17 commented Oct 6, 2024

Currently the go bindings do not work. This solution is based on tree-sitter/tree-sitter-c@927da1f

This commit also regenerates the config file and bindings from tree-sitter HEAD

@ribru17
Copy link
Author

ribru17 commented Oct 8, 2024

cc @amaanq @ObserverOfTime

@clason
Copy link
Contributor

clason commented Oct 8, 2024

I'd prefer to stick to releases for generated files, as a matter of principle.

@ribru17
Copy link
Author

ribru17 commented Oct 8, 2024

Sure that's smart. So only keep the go changes?

@clason
Copy link
Contributor

clason commented Oct 8, 2024

I have no opinion on those :)

@ribru17
Copy link
Author

ribru17 commented Oct 8, 2024

I think earlier I had it with no generated files and CI failed because it wanted the new tree-sitter.json, so I'll keep that as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants