refactor!: un-alias strings in anonymous nodes #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It does not make much sense to alias them here since they are not identifiers, they are strings that represent a literal node rather than a named node in the queries
|
Can you check whether this will affect https://github.com/neovim/neovim/blob/2c6b6358722b2df9160c3739b0cea07e8779513f/runtime/lua/vim/treesitter/_query_linter.lua#L66-L78 |
|
It does not, since anonymous_node's child is captured as a wildcard rather than explicitly seeking for However #39 does since |
clason
changed the title
|
I'm ok with this. |
clason
approved these changes
May 25, 2024
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When viewing or using a parse tree of a query file in the parser's current state, all strings in an anonymous node are aliased to an identifier, thus making it seem like it's an identifier, when it's actually a string. It does not make much sense to alias them here since they are not identifiers, they are strings that represent a literal node rather than a named node in the queries
Solution
Un-alias strings to identifiers in anonymous nodes