Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Anchor fixes #28

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Anchor fixes #28

merged 3 commits into from
Feb 13, 2024

Conversation

amaanq
Copy link
Member

@amaanq amaanq commented Feb 13, 2024

Closes #26

@clason
Copy link
Contributor

clason commented Feb 13, 2024 •
edited
Loading 

- #define STATE_COUNT 243
+ #define STATE_COUNT 313

That's what I was worried about... As we use the parser for (potentially very large) tree view in Neovim, I'm hesitant whether this is worth it?

@amaanq
Copy link
Member Author

amaanq commented Feb 13, 2024 •
edited
Loading

313 is nothing really, like way smaller than most other small grammars already and is only a 4kb increase in compiled size for me (40kb -> 44kb)

lucario387
lucario387 reviewed Feb 13, 2024
View reviewed changes
grammar.js Outdated Show resolved Hide resolved
@amaanq
Copy link
Member Author

amaanq commented Feb 13, 2024

back to 243 anyways

@amaanq amaanq merged commit a49ed4f into master Feb 13, 2024
2 checks passed
@clason clason deleted the anchors branch February 13, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucario387 lucario387 lucario387 left review comments

@clason clason clason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in legal expression with anchor
3 participants
@amaanq @clason @lucario387