Skip to content

Ignore elapsed_time #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
cyberdelia merged 0 commits into from
Feb 10, 2021
Merged

Ignore elapsed_time #129

cyberdelia merged 0 commits into from
Feb 10, 2021

Conversation

@cyberdelia
Copy link
Contributor

@cyberdelia cyberdelia commented Feb 10, 2021

Ignore elapsed_time, since we always return the value 0.

@cyberdelia cyberdelia requested a review from a team February 10, 2021 02:54
@k0kubun
Copy link

k0kubun commented Feb 10, 2021

since we always return the value 0.

You mean js['elapsed_time'] is nil, because the field doesn't exist, and nil.to_f is 0.0, right?

k0kubun
k0kubun approved these changes Feb 10, 2021
View reviewed changes
Copy link

@k0kubun k0kubun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

confirmed elasped_time does exist but it's always 0.

@cyberdelia cyberdelia merged commit 8690f20 into master Feb 10, 2021
@cyberdelia cyberdelia deleted the elapsed branch February 10, 2021 20:39
@tung-vu-td tung-vu-td mentioned this pull request Mar 3, 2021
Merged
tung-vu-td added a commit that referenced this pull request Mar 4, 2021
@tung-vu-td
Release 1.0.8 (#130)
b1271e5 
Ignore elapsed_time #129
Handle client erros #127
SeanEmac pushed a commit that referenced this pull request Mar 20, 2025
@tung-vu-td
Release 1.0.8 (#130)
716aaa8 
Ignore elapsed_time #129
Handle client erros #127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@k0kubun k0kubun k0kubun approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cyberdelia @k0kubun