use TD_AGENT_ARGS/DAEMON_ARGS when executing configtest #60
Conversation
| cmd=$(echo $cmd | sed -e "s/--log[ ]*[^ ]*//") | ||
| cmd=$(echo $cmd | sed -e "s/--user[ ]*[^ ]*//") | ||
| cmd=$(echo $cmd | sed -e "s/--group[ ]*[^ ]*//") | ||
| cmd=$(echo $cmd | sed -e "s/--daemon[ ]*[^ ]*//") |
There was a problem hiding this comment.
This --daemon handling is needed in redhat/td-agent.init?
There was a problem hiding this comment.
It' ok to also add '--daemon' handling to the redhat file. I ignored this just because no '--daemon' exists in the default 'TD_AGNET_ARGS' of 'redhat/td-agent.init'
|
Maybe output |
|
I agree with the idea that logs configtest results for debugging. |
|
Updated. Removes only |
| /usr/sbin/td-agent --user td-agent --group td-agent --dry-run -q | ||
| cmd="$TD_AGENT_ARGS" | ||
| cmd=$(echo $cmd | sed -e "s/--daemon[ ]*[^ ]*//") | ||
| cmd="$cmd --dry-run -q" |
There was a problem hiding this comment.
Maybe $DAEMON_ARGS is needed like cmd="$cmd $DAEMON_ARGS --dry-run -q".
I'm not sure why TD_AGENT_ARGS and DAEMON_ARGS are separated...
|
Updated. Include $DAEMON_ARGS in $cmd of redhat init file. |
|
Is it ok to have |
|
@choplin |
|
Thx, remove it. |
use TD_AGENT_ARGS/DAEMON_ARGS when executing configtest
|
Thx! |
No description provided.