This repository was archived by the owner on Nov 9, 2017. It is now read-only.
Use own mechanizm instead of killproc in stop #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stopping Fluentd process via killproc has the problem. killproc can't wait SIGTERM shutdown and it is not fit for Fluentd shutdown. So we follow MySQL-way to prevent duplicate td-agent process problem in RPM. On Debian family, we use start-stop-daemon and it doesn't have this problem.
|
Some users test this new stop and there is no problem. |
repeatedly
added a commit
that referenced
this pull request
Jun 18, 2014
Use own mechanizm instead of killproc in stop
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stopping Fluentd process via killproc has the problem.
killproc can't wait SIGTERM shutdown and it is not fit for Fluentd shutdown.
So we follow MySQL-way to prevent duplicate td-agent process problem in RPM.
On Debian family, we use start-stop-daemon and it doesn't have this problem.