Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base64 and logger gem as dependency for Ruby 3.4 and 3.5 #147

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

Watson1978
Copy link
Contributor

@Watson1978 Watson1978 commented Sep 2, 2024

The base64 gem was marked as bundled gem for Ruby 3.4.
Ref. ruby/ruby@6500f85

And, the logger gem was marked as bundled gem for Ruby 3.5.
Ref. ruby/ruby@d7e558e

This patch will suppress the following warning message:

socket_manager.rb:23: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec.

config_loader.rb:18: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.

@Watson1978 Watson1978 marked this pull request as draft September 2, 2024 01:52
@Watson1978 Watson1978 changed the title Add base64 gem as dependency for Ruby 3.4 Add base64 and logger gem as dependency for Ruby 3.4 and 3.5 Sep 2, 2024
@Watson1978 Watson1978 marked this pull request as ready for review September 2, 2024 01:59
The `base64` gem was marked as bundled gem for Ruby 3.4.
Ref. ruby/ruby@6500f85

And, the `logger` gem was marked as bundled gem for Ruby 3.5.
Ref. ruby/ruby@d7e558e

This patch will suppress the following warning message:

```
socket_manager.rb:23: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec.

config_loader.rb:18: warning: logger was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
```

Signed-off-by: Shizuo Fujita <fujita@clear-code.com>
@ashie ashie merged commit 5e9d11e into treasure-data:master Sep 3, 2024
10 checks passed
@ashie
Copy link
Collaborator

ashie commented Sep 3, 2024

Thanks!

@Watson1978 Watson1978 deleted the base64 branch September 4, 2024 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants