fix height of StepItem.kt

traviss64 · Feb 11, 2022 · 39fa452 · 39fa452
1 parent 0d2134b
commit 39fa452
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 7 deletions.
diff --git a/app/src/main/java/com/omelan/cofi/components/StepItem.kt b/app/src/main/java/com/omelan/cofi/components/StepItem.kt
@@ -34,6 +34,7 @@ fun StepListItem(
     onClick: ((Step) -> Unit)? = null
 ) {
     val constraintModifier = modifier
+        .heightIn(min = 42.dp)
         .animateContentSize()
         .fillMaxWidth()
         .padding(vertical = Spacing.small)
@@ -43,11 +44,7 @@ fun StepListItem(
             role = Role.Button,
             interactionSource = remember { MutableInteractionSource() },
             indication = rememberRipple(bounded = true),
-        ).apply {
-            if (onClick != null) {
-                heightIn(min = 42.dp)
-            }
-        }
+        )
 
     ConstraintLayout(
         modifier = constraintModifier
@@ -120,8 +117,8 @@ fun StepListItemPreview() {
         step = Step(
             id = 0,
             name = "Somebody once told me the world is gonna roll me I ain't the sharpest " +
-                "tool in the shed She was looking kind of dumb with her finger and her thumb " +
-                "In the shape of an \"L\" on her forehead",
+                    "tool in the shed She was looking kind of dumb with her finger and her thumb " +
+                    "In the shape of an \"L\" on her forehead",
             time = 35.toMillis(),
             type = StepType.WATER,
             value = 60,

diff --git a/fastlane/metadata/android/en-US/images/phoneScreenshots/3_en-US.png b/fastlane/metadata/android/en-US/images/phoneScreenshots/3_en-US.png
diff --git a/fastlane/metadata/android/en-US/images/phoneScreenshots/4_en-US.png b/fastlane/metadata/android/en-US/images/phoneScreenshots/4_en-US.png
diff --git a/fastlane/metadata/android/en-US/images/phoneScreenshots/5_en-US.png b/fastlane/metadata/android/en-US/images/phoneScreenshots/5_en-US.png
diff --git a/fastlane/metadata/android/en-US/images/phoneScreenshots/6_en-US.png b/fastlane/metadata/android/en-US/images/phoneScreenshots/6_en-US.png