Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change notices functions to REST API #203

Merged
merged 4 commits into from
Sep 20, 2024
Merged

Change notices functions to REST API #203

merged 4 commits into from
Sep 20, 2024

Conversation

Snuffy2
Copy link
Collaborator

@Snuffy2 Snuffy2 commented Sep 20, 2024 •
edited
Loading

Removed are_notices_pending and incorporated it into get_notices

@Snuffy2 Snuffy2 marked this pull request as ready for review September 20, 2024 01:11
@Snuffy2 Snuffy2 added the enhancement Enhancing existing functionality label Sep 20, 2024
@alexdelprete alexdelprete merged commit 0228e5f into travisghansen:main Sep 20, 2024
2 checks passed
@Snuffy2 Snuffy2 deleted the Change-notices-functions-to-REST-API branch September 20, 2024 01:16
@Snuffy2
Copy link
Collaborator Author

Snuffy2 commented Sep 20, 2024

Let me run this version on my system overnight to make sure there aren't any unintended conflicts with all of these PRs. If everything looks ok, I'd say we can put out a release tomorrow (or whenever)

@Snuffy2
Copy link
Collaborator Author

Snuffy2 commented Sep 20, 2024

Looks ok to me to release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement Enhancing existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Snuffy2 @alexdelprete