Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert instance entity naming #151

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

Snuffy2
Copy link
Collaborator

@Snuffy2 Snuffy2 commented Sep 5, 2024

Change the naming of the instance entities back to the logic pre-v0.1.22

@Snuffy2 Snuffy2 marked this pull request as ready for review September 5, 2024 03:00
@Snuffy2 Snuffy2 requested a review from alexdelprete September 5, 2024 03:00
@Snuffy2
Copy link
Collaborator Author

Snuffy2 commented Sep 5, 2024

@alexdelprete, @travisghansen I'd say that #149, #150 and #151 can be packaged up into the next release if you're ok with the PRs. I'd suggest that this gets released as a Breaking Change (possibly bumping the version to v0.2.0) due to the permissions changes even though they technically started with v0.1.22.

As for whether to list and recommend the individual permissions or admin, I'd agree that we might as well just recommend admin now so we dont have to keep adding on permissions piecemeal as we move functions to the REST API.

I likely wont be able to package up the release, explain the breaking change and new permission, and update the readme until the weekend so feel free to do it sooner if you'd like.

@travisghansen
Copy link
Owner

I really don’t have much time to properly review, all of the above seems perfectly reasonable though so release whenever is convenient for you.

@alexdelprete
Copy link
Collaborator

I likely wont be able to package up the release, explain the breaking change and new permission, and update the readme until the weekend so feel free to do it sooner if you'd like.

I have some time available to do this today. Just let me know what you want to write in the readme regarding the "breaking change": for me, it's just that we now require admin role for the user.

Also, do we want to first release a beta for a quick test or go straight to the stable release?

Let me know, I'll start reviewing the PRs and then merge them.

@alexdelprete alexdelprete merged commit 0aec921 into travisghansen:main Sep 5, 2024
2 checks passed
@Snuffy2 Snuffy2 deleted the Revert-instance-naming branch September 5, 2024 21:42
@Snuffy2 Snuffy2 added the bugfix Fix something that isn't working label Sep 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fix something that isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants