Handle local imports with quoted paths #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
travisbrown
approved these changes
Apr 16, 2020
| if (path2.isAbsolute) canonicalize(Classpath(path2)) | ||
| else canonicalize(Classpath(path.getParent.resolve(path2))) | ||
| for { | ||
| parent <- LocalFile[F](path) |
There was a problem hiding this comment.
It's not a big deal, but what do you think about using F.map2 instead of for-comprehensions in cases like this where there's not a data dependency? It's a little more correct, and in my view it also reads a bit more nicely.
| @@ -58,6 +65,16 @@ class ImportResolutionSuite extends FunSuite { | |||
| assert(resolve(expr) == expected) | |||
| } | |||
|
|
|||
| //TODO - dependent on https://github.com/travisbrown/dhallj/issues/34 | |||
There was a problem hiding this comment.
I think we can merge this for now as it is here. I'll look into failing more reasonably in the parser on quoted URL paths this weekend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling remote imports with quoted paths is blocked on #34