Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and add tests around the behaviour of classpath imports #33

Merged
merged 2 commits into from
Apr 16, 2020

Conversation

TimWSpence
Copy link
Collaborator

Initial documentation and testing of behaviour of classpath imports. Not covered by the spec and subject to change as we understand use-cases better.

Copy link
Owner

@travisbrown travisbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

TimWSpence added a commit to TimWSpence/dhall-lang that referenced this pull request Apr 16, 2020
When implementing import resolution for travisbrown/dhallj#33
I discovered that I could pass the import acceptance tests without handling
quoted paths. This should probably not be the case!
@travisbrown travisbrown merged commit 01cc287 into master Apr 16, 2020
@travisbrown travisbrown deleted the classpath-import-semantics branch April 20, 2020 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants