Classpath import type #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial scaffolding
Implement manually as java.nio.file.Path does not normalize according to the Dhall spec
travisbrown
approved these changes
Apr 16, 2020
There was a problem hiding this comment.
This looks good to me! I was originally thinking this could be a flag parameter on onLocalImport, but on second thought I think the approach here is better.
I agree that we can wait on testing the CBOR encoding and decoding, but we should be sure to open an issue for that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces new
classpath:/path/to/filesyntax for classpath imports and hence separates handling of local file imports and classpath imports.The exact semantics of classpath imports are yet to be defined but (importantly!) this means that we can enable all the import-related acceptance tests and pass them using local file imports