Typecheck fully resolved imports #24
Conversation
TimWSpence
force-pushed
the
typecheck-fully-resolved-imports
branch
from
ab780ca
to
823171e
Compare
| with ResolvingInput | ||
| class AlphaNormalizationSuite(val base: String) extends ExprOperationAcceptanceSuite(_.alphaNormalize) with ParsingInput | ||
| class NormalizationSuite(val base: String) extends ExprOperationAcceptanceSuite(_.normalize) with CachedResolvingInput | ||
| class NormalizationUSuite(val base: String) extends ExprOperationAcceptanceSuite(_.normalize) with ParsingInput |
There was a problem hiding this comment.
I'm not sure about the U suffix here. What does it mean?
There was a problem hiding this comment.
It means I wanted to call it Unit but that name was already taken 😂
| @@ -25,6 +25,9 @@ class TypeCheckingSimpleSuite extends CachingTypeCheckingSuite("type-inference/s | |||
| class TypeCheckingUnitSuite extends CachingTypeCheckingSuite("type-inference/success/unit") | |||
| class TypeCheckingRegressionSuite extends TypeCheckingSuite("type-inference/success/regression") | |||
| class TypeCheckingOtherSuite extends TypeCheckingSuite("type-inference/success") { | |||
| //TODO prelude is WAY too slow | |||
There was a problem hiding this comment.
What's way too slow? To be honest I'd rather hold off on this change for now and keep it easy to make sure we're correctly type-checking the unnormalized prelude in CI, etc.
There was a problem hiding this comment.
The prelude test is what was hanging and aborting the CI builds. We can do, it just means we don't conform to the spec and will have to disable one or two other tests and I thought most of this was covered in the Prelude suites anyway
There was a problem hiding this comment.
Okay, let's go ahead and merge this after the Prelude name change revert and I'll take a closer look later at making sure we can run this.
There was a problem hiding this comment.
👍 I'm going to have a look into the Haskell implementation to see if it does any optimization (caching type-checking results, etc)
| class HashingPreludeBoolOddSuite extends HashingSuite("semantic-hash/success/prelude/Bool/odd") | ||
| class HashingPreludeBoolOrSuite extends HashingSuite("semantic-hash/success/prelude/Bool/or") | ||
| class HashingPreludeBoolShowSuite extends HashingSuite("semantic-hash/success/prelude/Bool/show") | ||
| class HashingBoolAndSuite extends HashingSuite("semantic-hash/success/prelude/Bool/and") |
There was a problem hiding this comment.
I think I'd like to keep it easy to distinguish the prelude tests from others (both in the results and with testOnly). I'm not necessarily against removing the Prelude from the test class name, but if we do I think these should go in a new org.dhallj.tests.acceptance.prelude package.
There was a problem hiding this comment.
Oh sorry!!! That was an unintentional sed change. Will revert
|
@TimWSpence Thanks! Will merge on green. |
No description provided.