Make duplicate imports cache private #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@TimWSpence This is a temporary adjustment to the additions in #18 that will let us publish an 0.1.1 today without breaking bincompat for the dhall-imports module. This doesn't change behaviour, it just keeps the duplicate imports cache out of the public API.
After 0.1.1 I've got some bigger changes in mind here that I want to run past you—in particular there are some issues related to visibility (e.g.
ResolveImportsVisitor.ImportContextis package-private butCanonicalization.canonicalizeis public), and I thinkResolveImportsVisitorprobably shouldn't be a case class, in part because of bincompat issues, but mostly because it's carrying around the client andSyncinstance.