Remove whitespace around list items #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firefox was showing the text of each line item beneath its bullet. See here: https://travisci.slack.com/archives/teal/p1462462487001036 This unsightly template formation seems required to prevent the generated whitespace being interpreted as paragraphs in Markdown. See this discussion: Shopify/liquid#216
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As reported by @solarce, Firefox was showing the text of each line item beneath its bullet. For example:
This unsightly template formation seems required to prevent the generated whitespace being interpreted as paragraphs in Markdown. See this discussion:
Shopify/liquid#216
Haml has
<and>to handle this kind of thing, hopefully eventually Liquid will get something like it.