Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force symlink creation (don't error if it already exists) #659

Merged
merged 1 commit into from
Aug 31, 2019

Conversation

zofrex
Copy link
Contributor

@zofrex zofrex commented Aug 31, 2019

Currently, reinstalling or upgrading mergerfs via the Makefile gives an error, because the symlink mount.mergerfs already exists:

ln -s "mergerfs" "/usr/local/bin/mount.mergerfs"
ln: /usr/local/bin/mount.mergerfs: File exists
gmake: *** [Makefile:153: install-mount.mergerfs] Error 1

This fixes that error by removing and recreating the symlink if it already exists, rather than erroring.

As this is a Makefile it would also be possible to make it do nothing if the symlink already exists, rather than recreating it. It seemed like the general pattern of the Makefile was not to worry about such things, but I could do it that way if you want.

@trapexit trapexit merged commit 23d365f into trapexit:master Aug 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants