Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the temporary fix for issue #32 #66

Closed
wants to merge 2 commits into from
Closed

Conversation

hlinero
Copy link
Member

@hlinero hlinero commented Feb 23, 2021

Issue #32 raised an issue about CHN data being incorrect for the year 1990 to 2001. Since ITF has updated the input CSV file for T001 with the corrections to such issue, this pull request removes the temporary fix we had created.

@hlinero hlinero requested a review from khaeru February 23, 2021 10:05
@codecov
Copy link

codecov bot commented Feb 23, 2021

Codecov Report

Merging #66 (7a2d4f0) into master (376def3) will increase coverage by 2.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
+ Coverage   53.21%   55.31%   +2.10%     
==========================================
  Files          39       42       +3     
  Lines        1603     1712     +109     
==========================================
+ Hits          853      947      +94     
- Misses        750      765      +15     
Impacted Files Coverage Δ
item/historical/scripts/T001.py 100.00% <ø> (ø)
item/cli.py 87.80% <0.00%> (ø)
item/__init__.py 100.00% <0.00%> (ø)
item/common.py 85.71% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 376def3...f8c93b7. Read the comment docs.

@khaeru khaeru removed their request for review February 23, 2021 11:18
khaeru added a commit that referenced this pull request May 3, 2021
Also closes #57/supersedes #66.
@khaeru
Copy link
Contributor

khaeru commented May 3, 2021

Superseded by #71.

@khaeru khaeru closed this May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants