[pull] master from jonasbb:master #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
…core This removes bitflags v1 and winapi from the lock file. windows* crates are updated to v0.52
In serde 1.0.196, the "invalid type" error message for floats started
adding a trailing ".0" if no decimal point was already part of the
formatted float, causing tests to fail like:
---- test_chrono_timestamp_seconds_with_frac stdout ----
error: expect test failed
--> serde_with/tests/chrono_0_4.rs:551:9
Expect:
----
invalid type: floating point `0`, expected a string at line 1 column 3
----
Actual:
----
invalid type: floating point `0.0`, expected a string at line 1 column 3
----
Change the tests to use a test value of 0.1, so the test will work both
pre- and post-serde 1.0.196.
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #61 +/- ##
=======================================
Coverage 66.55% 66.55%
=======================================
Files 38 38
Lines 2473 2473
=======================================
Hits 1646 1646
Misses 827 827 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )