♻️ Make bound virtual#279
Merged
transmissions11 merged 8 commits intotransmissions11:mainfrom Jul 5, 2022
Merged
Conversation
vminkov
changed the title
Owner
|
dont want this to be public, happy to make it virtual but its really not a public method |
Owner
|
DSTestPlus and Test.sol are not really meant to be used together rn |
vminkov
changed the title
vminkov
changed the title
Contributor
Author
|
@transmissions11 , can you, please, approve the github workflow for the PR? The checklist has been done. Thanks and the |
transmissions11
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is another way to resolve the breaking compatibility of
solmate/test/DSTestPlus.solandforge-std/Test.solwhen used together as parents in an inheriting testing contractChecklist
Ensure you completed all of the steps below before submitting your pull request:
forge snapshot?npm run lint?forge test?Pull requests with an incomplete checklist will be thrown out.