Conversation
Meta shut down the Instagram Basic Display API on December 4, 2024, permanently breaking @uppy/instagram. This removes all Instagram support from both the client and Companion server. Removed: - Instagram from @uppy/remote-sources (src, package.json, keywords) - Instagram export from uppy bundle (bundle.ts, index.ts, package.json) - Companion Instagram OAuth provider (provider/index.js, grant.js) - Companion standalone helper Instagram env vars (helper.js, env_example) - All Companion Instagram tests (providers.test.js, provider-manager.test.js, fixtures/index.js, mockserver.js) The @uppy/instagram package directory is retained for a final deprecation release with a console warning before removal from the registry. Closes transloadit#5455
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 404243f8c6
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ...defaults, | ||
| callback: '/instagram/callback', | ||
| }, | ||
| facebook: { |
There was a problem hiding this comment.
This deletion removes the instagram Grant provider, but packages/@uppy/companion/test/provider-manager.test.js still dereferences grantConfig.instagram in multiple cases (secret-file, undefined-key, and oauthDomain redirect checks). After this change, those accesses become undefined/throw, so the Companion test suite will fail until those assertions and env setup are cleaned up consistently.
Useful? React with 👍 / 👎.
| Facebook, | ||
| GoogleDrive, | ||
| Instagram, | ||
| OneDrive, |
There was a problem hiding this comment.
Removing Instagram from availablePlugins changes the formatted error message for unknown sources, but packages/@uppy/remote-sources/src/index.test.ts still expects the old string that includes Instagram. That makes the invalid-plugin test fail deterministically even though runtime behavior is otherwise correct, so the test expectation should be updated with the new provider list.
Useful? React with 👍 / 👎.
….com/qxprakash/uppy into fix/5455-remove-instagram-deprecated
1 participant
closes #5455 , this PR removes all Instagram support from both the client and Companion server.
Removed:
The @uppy/instagram package directory is retained for a final deprecation release with a console warning before removal from the registry.