-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add Mongolian (mn_MN) locale support #6109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added Mongolian locale
🦋 Changeset detectedLatest commit: 1230ab6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
CI still failing, run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
| aspectRatioSquare: 'Дөрвөлжин тайралт', | ||
| authAborted: 'Нэвтрэлт цуцлагдсан', | ||
| authenticate: 'Холбогдох', | ||
| authenticateWith: 'Connect to %{pluginName}', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Untranslated English strings in Mongolian locale file
The authenticateWith value is 'Connect to %{pluginName}' and revert value is 'Reset' - both are in English instead of Mongolian. All other strings in this locale file are properly translated to Mongolian, indicating these two were accidentally left untranslated. This may be causing the CI check failure mentioned in the PR discussion.
Additional Locations (1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi again,
I'm sorry I couldn't figure out 😅. if possible can you create the localization file by yourself and commit to the repo?
Because.
- I have installed whole uppy projec as mentioned https://github.com/transloadit/uppy/blob/main/.github/CONTRIBUTING.md.
- Runned yarn check, yarn typecheck with the localization file (mn_MT.ts) in the "packages/@uppy/locale/src/mn_MT.ts
But it has passed without any error.
I have attached translation file here.
mn_MN.ts
Sorry for bothering!
thanks again and have a nice day!
Added Mongolian locale
Note
Adds Mongolian (mn_MN) locale with translations and pluralization, registering it in Uppy and marking a minor release for @uppy/locales.
packages/@uppy/locales/src/mn_MN.tswith Mongolian strings for core UI (upload, camera, errors, plugins) and a simple pluralization rule (1vs other).globalThis.Uppy.locales.mn_MN..changeset/chatty-worms-cheer.mdto publish a minor version of@uppy/locales.Written by Cursor Bugbot for commit 1230ab6. This will update automatically on new commits. Configure here.