Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add types for css files #5591

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Add types for css files #5591

merged 2 commits into from
Jan 13, 2025

Conversation

Murderlon
Copy link
Member

@Murderlon Murderlon commented Jan 9, 2025 •
edited
Loading

Before

├── dist
│   ├── style.css
│   └── style.min.css

After

├── dist
│   ├── style.css
│   ├── style.d.css.ts
│   ├── style.min.d.css.ts
│   └── style.min.css

@Murderlon Murderlon requested a review from remcohaszing January 9, 2025 12:57
@Murderlon Murderlon self-assigned this Jan 9, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 9, 2025

Diff output files 
No diff

remcohaszing
remcohaszing reviewed Jan 9, 2025
View reviewed changes
@Murderlon @remcohaszing
Apply suggestions from code review
cdb4b26 
Co-authored-by: Remco Haszing <remcohaszing@gmail.com>
@Murderlon Murderlon merged commit a2f1b0c into main Jan 13, 2025
16 checks passed
@Murderlon Murderlon deleted the css-types branch January 13, 2025 12:47
@github-actions github-actions bot mentioned this pull request Jan 15, 2025
Merged
github-actions bot added a commit that referenced this pull request Jan 15, 2025
@github-actions
Release: uppy@4.13.0 (#5605)
ec8a3fe 
| Package         | Version | Package         | Version |
| --------------- | ------- | --------------- | ------- |
| @uppy/aws-s3    |   4.2.2 | @uppy/unsplash  |   4.3.2 |
| @uppy/companion |   5.5.0 | uppy            |  4.13.0 |

- @uppy/aws-s3: always set S3 meta to UppyFile & include key (Merlijn Vos / #5602)
- @uppy/companion: fix forcePathStyle boolean conversion (Mikael Finstad / #5308)
- meta: Fix Webpack CI (Merlijn Vos / #5604)
- @uppy/aws-s3: allow uploads to fail/succeed independently (Merlijn Vos / #5603)
- meta: Add types for css files (Merlijn Vos / #5591)
- @uppy/unsplash: make utmSource optional (Merlijn Vos / #5601)
- meta: build(deps): bump docker/setup-qemu-action from 3.2.0 to 3.3.0 (dependabot[bot] / #5599)
- meta: build(deps): bump docker/build-push-action from 6.10.0 to 6.11.0 (dependabot[bot] / #5600)
- @uppy/companion: add COMPANION_TUS_DEFERRED_UPLOAD_LENGTH (Dominik Schmidt / #5561)
Murderlon added a commit that referenced this pull request Jan 23, 2025
@Murderlon
Merge branch 'main' into uploaders-with-hosted-companion
5bec1c1 
* main: (38 commits)
  Release: uppy@4.13.1 (#5617)
  @uppy/tus: fix resumeFromPreviousUpload race condition (#5616)
  @uppy/aws-s3: Fixed default shouldUseMultipart (#5613)
  build(deps): bump docker/build-push-action from 6.11.0 to 6.12.0 (#5611)
  @uppy/aws-s3: remove console.error (#5607)
  @uppy/companion: unify http error responses (#5595)
  Release: uppy@4.13.0 (#5605)
  @uppy/aws-s3: always set S3 meta to UppyFile & include key (#5602)
  @uppy/companion: fix forcePathStyle boolean conversion (#5308)
  Fix Webpack CI (#5604)
  @uppy/aws-s3: allow uploads to fail/succeed independently (#5603)
  Revert "@uppy/aws-s3: allow uploads to fail/succeed independently"
  @uppy/aws-s3: allow uploads to fail/succeed independently
  Add types for css files (#5591)
  @uppy/unsplash: make utmSource optional (#5601)
  build(deps): bump docker/setup-qemu-action from 3.2.0 to 3.3.0 (#5599)
  build(deps): bump docker/build-push-action from 6.10.0 to 6.11.0 (#5600)
  @uppy/companion: add COMPANION_TUS_DEFERRED_UPLOAD_LENGTH (#5561)
  Release: uppy@4.12.2 (#5590)
  Import types consistently from @uppy/core (#5589)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@remcohaszing remcohaszing remcohaszing left review comments

Assignees

@Murderlon Murderlon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Murderlon @remcohaszing