Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion feedback and accepting altered suggestions #4659

Merged
merged 26 commits into from
Apr 29, 2016
Merged

Suggestion feedback and accepting altered suggestions #4659

merged 26 commits into from
Apr 29, 2016

Commits on Apr 29, 2016

  1. Adjust suggestions UI for pluralform units 

    - Put time under all plural forms;
- Show buttons only once;
- Show user avatar only once;

Fix translate#4688
    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    335baa2 View commit details
    Browse the repository at this point in the history

  2. Support rejecting/accepting suggestions with comments 

    - Add `body` to xhr handlers in UnitAPI.js;
- Save comments via UnsecureCommentForm;
    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    4060a85 View commit details
    Browse the repository at this point in the history

  3. Add suggestion feedback form React component 

    This commit adds accept/reject white icons used in the form.
    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    350ac7f View commit details
    Browse the repository at this point in the history

  4. Show suggestion feedback form 

    - Edit css styles to render form properly;
- Adjust editor HTML template;
- Add JS handlers to work with suggestion feedback form;
    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    a99475c View commit details
    Browse the repository at this point in the history

  5. Add backend support for suggestion alterations via submit 

    Accepting a suggestion with alteration can be handled as:
- accepting the suggestion without alterations;
- editing accepted suggestion and submit new translation.
Refs. translate#4629
    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    9250767 View commit details
    Browse the repository at this point in the history

  6. Close suggestion on click or esc button

    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    e4a49a1 View commit details
    Browse the repository at this point in the history

  7. Prevent loss of unsaved changes in feedback form

    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    96577ee View commit details
    Browse the repository at this point in the history

  8. Show comments on accept/reject suggestions in timeline

    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    64fd646 View commit details
    Browse the repository at this point in the history

  9. Force cursor to pointer over collapsed suggestion

    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    c1b2c7d View commit details
    Browse the repository at this point in the history

  10. Use UnitForm for getting clean data for suggestion and comment

    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    d7bf7a9 View commit details
    Browse the repository at this point in the history

  11. Get comment list via suggestion list (no GenericRelation used)

    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    6726e3c View commit details
    Browse the repository at this point in the history

  12. Add test for timeline with comments

    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    c053133 View commit details
    Browse the repository at this point in the history

  13. Set unit.state to TRANSLATED before altering accepted suggestion 

    If suggestion is provided in submit request data we accept this suggestion
before submitting. When we calculate updated_fields during submission
we should cout unit.state as already TRANSLATED.
    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    526fc49 View commit details
    Browse the repository at this point in the history

  14. Support rtl in suggestion altering area

    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    4c3c615 View commit details
    Browse the repository at this point in the history

  15. Put altering of accepted suggestion in a separate timeline entry

    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    3e8ab9a View commit details
    Browse the repository at this point in the history

  16. Add tests for accept/reject with comments

    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    c001c11 View commit details
    Browse the repository at this point in the history

  17. Avoid passing PTL.editor as parameter to component

    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    668d228 View commit details
    Browse the repository at this point in the history

  18. Close suggestion before unit transitions

    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    ad3879e View commit details
    Browse the repository at this point in the history

  19. Cleanup: use DOM API instead of jQuery

    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    dfae55d View commit details
    Browse the repository at this point in the history

  20. Cleanup: rename props accoding styleguide

    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    2bd73b6 View commit details
    Browse the repository at this point in the history

  21. Use autoFocus attribute instead of direct call (autosize is supported… 

    … by default)
    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    22746b6 View commit details
    Browse the repository at this point in the history

  22. Avoid accessing to internal componet attributes

    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    ef12779 View commit details
    Browse the repository at this point in the history

  23. Use handlers instead of working methods

    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    727c254 View commit details
    Browse the repository at this point in the history

  24. Unmount suggestion feedback component

    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    cedec4b View commit details
    Browse the repository at this point in the history

  25. Bind component event handlers 

    It allows to refer to `this` in the handlers instead of `PTL.editor`.
    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    dd4e1c4 View commit details
    Browse the repository at this point in the history

  26. Force flushing of default django-cache

    @ta2-1
    ta2-1 committed Apr 29, 2016
    Configuration menu
    Copy the full SHA
    c099ab4 View commit details
    Browse the repository at this point in the history