-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notify suggester about accept/reject suggestion comment #5041
Comments
i think the priority here is more notifying of accept/reject actions than just the comments |
Suggesters can benefit much more from comments on accept/reject, so IMHO that is the priority. But I don't see why both can't be achieved at the same time. |
Accepting suggestion with changes does not yet send email. Part of translate#5041.
Accepting suggestion with changes does not yet send email. Part of translate#5041.
Accepting suggestion with changes does not yet send email. Part of translate#5041.
Accepting suggestion with changes does not yet send email. Part of translate#5041.
Accepting suggestion with changes does not yet send email. Part of translate#5041.
Accepting suggestion with changes does not yet send email. Part of translate#5041.
This is now fixed. |
Does reviewing's notifications by email work with the final release (2.8.2)? |
Hi all, same question as above. Did this feature ever make it into the latest 2.8.2 release? If not, is there a way to cherry-pick it? Thanks! |
Suggesters must be notified comments on accepted suggestions, and most importantly, rejected suggestions. Without this the accept/reject suggestions feature now in place (#4629) is basically useless.
Whether that notification should happen by email, or using GitHub-like notifications in Pootle UI, or both, is something that needs agreement.
Related #5040.
The text was updated successfully, but these errors were encountered: