Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify suggester about accept/reject suggestion comment #5041

Closed
unho opened this issue Aug 10, 2016 · 5 comments
Closed

Notify suggester about accept/reject suggestion comment #5041

unho opened this issue Aug 10, 2016 · 5 comments

Comments

@unho
Copy link
Member

unho commented Aug 10, 2016

Suggesters must be notified comments on accepted suggestions, and most importantly, rejected suggestions. Without this the accept/reject suggestions feature now in place (#4629) is basically useless.

Whether that notification should happen by email, or using GitHub-like notifications in Pootle UI, or both, is something that needs agreement.

Related #5040.

@phlax
Copy link
Member

phlax commented Aug 10, 2016

i think the priority here is more notifying of accept/reject actions than just the comments

@unho
Copy link
Member Author

unho commented Aug 10, 2016

Suggesters can benefit much more from comments on accept/reject, so IMHO that is the priority. But I don't see why both can't be achieved at the same time.

@phlax phlax added this to the 2.8.0 milestone Aug 10, 2016
unho added a commit to unho/pootle that referenced this issue Aug 12, 2016
Accepting suggestion with changes does not yet send email.

Part of translate#5041.
unho added a commit to unho/pootle that referenced this issue Aug 12, 2016
Accepting suggestion with changes does not yet send email.

Part of translate#5041.
unho added a commit to unho/pootle that referenced this issue Aug 12, 2016
Accepting suggestion with changes does not yet send email.

Part of translate#5041.
unho added a commit to unho/pootle that referenced this issue Aug 12, 2016
unho added a commit to unho/pootle that referenced this issue Aug 12, 2016
Accepting suggestion with changes does not yet send email.

Part of translate#5041.
unho added a commit to unho/pootle that referenced this issue Aug 12, 2016
unho added a commit to unho/pootle that referenced this issue Aug 12, 2016
unho added a commit to unho/pootle that referenced this issue Aug 12, 2016
Accepting suggestion with changes does not yet send email.

Part of translate#5041.
unho added a commit to unho/pootle that referenced this issue Aug 12, 2016
unho added a commit to unho/pootle that referenced this issue Aug 12, 2016
Accepting suggestion with changes does not yet send email.

Part of translate#5041.
unho added a commit to unho/pootle that referenced this issue Aug 12, 2016
@unho unho modified the milestones: 2.8.1, 2.8.0 Dec 1, 2016
@phlax phlax modified the milestones: 2.9.0, 2.10.1 Sep 6, 2017
@unho
Copy link
Member Author

unho commented Sep 6, 2017

This is now fixed.

@unho unho closed this as completed Sep 6, 2017
@eefahd
Copy link

eefahd commented Dec 23, 2017

Does reviewing's notifications by email work with the final release (2.8.2)?
Because I configured the email and tested it by (pootle sendtestemail) and it worked, but no email is sent after reviewings.

@qguv
Copy link

qguv commented Sep 27, 2021

Hi all, same question as above. Did this feature ever make it into the latest 2.8.2 release? If not, is there a way to cherry-pick it? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants