Repository navigation
fix(preview): restore canon root resolver for normative layout - #608
Merged
Merged
Conversation
Restores findCanonRootPath and findModelRootPath that were accidentally deleted in PR #603. The resolver searches for transitrix.yaml to locate the model root, then resolves canon/ from there (normative layout), with fallback to legacy basename-canon walk. Includes the two unit tests that verify both normative and legacy layouts resolve correctly. Deleting the tests without deleting the resolver would allow a future merge to drop the walker again silently. Fixes the regression in 3.6.0 where the fix was described in release notes but missing from the published VSIX. Fixes transitrix-hq#485. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
📊 Metrics Regression Report✅ All metrics within tolerance Summary
Detailsai-expense-approval.bpmn.transitrix.yaml
feature-release.bpmn.transitrix.yaml
large-cyclic-workflow.bpmn.transitrix.yaml
order-fulfillment.bpmn.transitrix.yaml
parallel-tracks.bpmn.transitrix.yaml
simple-approval.bpmn.transitrix.yaml
simple-linear.bpmn.transitrix.yaml
small-dense-approval.bpmn.transitrix.yaml
xlarge-stress-test.bpmn.transitrix.yaml
|
5 tasks done
transitrix
added a commit
that referenced
this pull request
Aug 31, 2026
Fold the accumulated changelog fragment into the existing 3.6.1 CHANGELOG section (added ahead of the version bump by #608), and bump versions: extension/root 3.6.0 -> 3.6.1, @transitrix/diagrams 1.12.0 -> 1.12.1, @transitrix/cli 2.8.0 -> 2.8.1 (moves together with diagrams per the release-version guard). Signed-off-by: transitrix <automation@transitrix.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Restores the catalogue-root resolver that was accidentally deleted in PR #603 (Gradle wrapper integrity pin). The resolver determines where the
canon/directory is located, which is needed for preview rendering to find canonical elements and relations.The fix restores two key functions:
findModelRootPath()— locates the adopter manifest (transitrix.yaml)findCanonRootPath()— resolvescanon/relative to the model root (normative layout), with fallback to the legacy walk-up-for-basename-canon (backward compatibility)Also restores the two unit tests that verify both layouts work correctly. These tests are load-bearing — without them, a future merge could accidentally delete the walker again without failing CI.
Test plan
canonAcceptance
views/<notation>/withtransitrix.yamlandcanon/as siblings resolves the cataloguecanon/elements/still resolve (legacy layout)Fixes transitrix-hq#485.
🤖 Generated with Claude Code