Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding eslint rules for explicit any and default export #110

Merged
merged 1 commit into from
Aug 17, 2022
Merged

Adding eslint rules for explicit any and default export #110

merged 1 commit into from
Aug 17, 2022

Conversation

devinmatte
Copy link
Member

Changes

  • Adds two new eslint rules to warn on
  • Adds import-eslint-plugin

@nathan-weinberg
Copy link
Member

LGTM, but I'll wait for others to approve

idreyn
idreyn approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@idreyn idreyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, sorry to let this one linger — LGTM!

@devinmatte devinmatte merged commit eb7ae88 into transitmatters:master Aug 17, 2022
@devinmatte devinmatte deleted the eslint-rules branch August 23, 2022 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@idreyn idreyn idreyn approved these changes

@mathcolo mathcolo Awaiting requested review from mathcolo

@nathan-weinberg nathan-weinberg Awaiting requested review from nathan-weinberg

@austinjpaul austinjpaul Awaiting requested review from austinjpaul

@thiteixeira thiteixeira Awaiting requested review from thiteixeira

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devinmatte @nathan-weinberg @idreyn