Adding datadog details to each lambda #36
Conversation
|
We may have found a bug in the datadog-chalice plugin 😅 |
devinmatte
changed the title
devinmatte
changed the title
|
Okay this PR has gotten smaller as a result of bugs in how datadog reads chalice layers, so now it just adds tags and a version for tracking. But this should still ship useful data in the meantime |
| @@ -20,14 +20,16 @@ | |||
| "iam_policy_file": "policy-newtrains.json" | |||
| }, | |||
| "bb_store_station_status": { | |||
| "iam_policy_file": "policy-bluebikes-store.json" | |||
| "iam_policy_file": "policy-bluebikes-store.json", | |||
| "lambda_timeout": 90 | |||
There was a problem hiding this comment.
Were these failing with default timeout?
There was a problem hiding this comment.
Yep just slightly. Discovered it when trying to add tracing. They were hitting timeout every time
There was a problem hiding this comment.
Doesn't look like it in s3, but hard to tell until we start using this data somewhere
| @@ -1,13 +1,21 @@ | |||
| #!/bin/bash -x | |||
|
|
|||
| if [[ -z "$MBTA_V2_API_KEY" ]]; then | |||
| echo "Must provide MBTA_V2_API_KEY in environment" 1>&2 | |||
| if [[ -z "$MBTA_V2_API_KEY" || -z "$DD_API_KEY" ]]; then | |||
There was a problem hiding this comment.
Do I need a DD_API_KEY to deploy locally now? Are there any docs/instructions we need to update?
There was a problem hiding this comment.
Only for deployment. Probably need to update docs. You can use any DD_API_KEY from our account, anyone with the datadog account can get it easily in the UI
ingestor/.chalice/resources.json
Outdated
There was a problem hiding this comment.
Is there a way to store env vars across the lambdas? Or we have to apply to each function?
There was a problem hiding this comment.
Best I could find was we need to do it per function. I couldn't find anything easier, I looked. Would love if we find something
…es' into datadog-env-variables
Tried to get traces and logs from all data-ingestion lambdas into datadog so we can set monitors, and more easily link issues between runs. Also will ship logs to datadog so we can more easily discover broken lambdas
Sadly, there's a bug in how they handle chalice, so, this is going to only do a minimal piece for now