Increase FeedInfo cache expiration time and read from config #368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@irees can you also add a line to docs/configuration.md? |
|
@drewda I added a line to docs/configuration.md. Considering it further, should it be in hours instead of seconds, to match the similar MAX_HOURS_SINCE_LAST_CONFLATE setting? I defaulted to seconds bc that is the value passed to cache expires_in:. |
|
@irees, this is fine for now. Important for us to document, but not necessary just yet to have complete consistency on timing units. |
drewda
added a commit
that referenced
this pull request
Feb 4, 2016
…ration Increase FeedInfo cache expiration time and read from config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default FeedInfo cache expiration time is now 4 hours (14400 seconds).
This setting can now be overridden via setting the config value or environment variable FEED_INFO_CACHE_EXPIRATION, in seconds.
Resolves #367