improve Sidekiq background job stability #292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a partial solution to #291
If job receives a huge number of stop IDs, it will load them into memory in batches, rather than all at once. In theory, the garbage collector will clear out each batch when it's no longer relevant. see also: https://github.com/mperham/sidekiq/wiki/Problems-and-Troubleshooting#memory-bloat another partial solution to #291
| @@ -2,7 +2,8 @@ class ConflateStopsWithOsmWorker | |||
| include Sidekiq::Worker | |||
|
|
|||
| def perform(stop_ids = []) | |||
| stops = Stop.where(id: stop_ids) | |||
| Stop.conflate_with_osm(stops) | |||
| stops = Stop.where(id: stop_ids).find_in_batches(batch_size: 1000) do |batch_of_stops| | |||
There was a problem hiding this comment.
Useless assignment to variable - stops. Did you mean stop_ids?
Line is too long. [90/80]
| CHANGE_PAYLOAD_MAX_ENTITIES = 1_000 | ||
| STOP_TIMES_MAX_LOAD = 100_000 | ||
| CHANGE_PAYLOAD_MAX_ENTITIES = Figaro.env.feed_eater_change_payload_max_entities.try(:to_i) || 1_000 | ||
| STOP_TIMES_MAX_LOAD = Figaro.env.feed_eater_stop_times_max_load.try(:to_i) || 100_000 |
drewda
added a commit
that referenced
this pull request
Jan 6, 2016
improve Sidekiq background job stability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #291