-
Notifications
You must be signed in to change notification settings - Fork 300
Conversation
Changes: * Update dependencies * `babel-preset-stage0` is now deprecated. I think it's best to let users just add what they need themselves. * warning about rollup postcss plugin using the onwrite hook: egoist/rollup-plugin-postcss#148 * move prop-types dependency from example to lib. It's weird to put this as a peer dependency, because we only import it in the library and a user may choose to not use prop-types or something different. * the specific versions babel-eslint and eslint are required by the latest version of react-scripts. * remove `react-dom` dependency from library (still used in example). It doesn't look like this is actually used. * add eslint-import-resolver-node (doesn't result in build error, but eslint does give an error without it)
I merged the previous changes from my own repo where I had updated the dependencies from the 2.6.7 version of the dependencies, in which babel 6 was still used.
I removed this in the library I created with this starter, because I don't need it, but forgot to remove it from the commit on this repo.
I don't know why this didn't happen automatically
Using "external-helpers" plugin with rollup-plugin-babel is deprecated, as it now automatically deduplicates your Babel helpers.
This should have been done right when upgrading to babel 7
Something is broken with the testing. When i try to run them myself it eats up way to much ram and the travis ci log says it's finding |
Hey! I've been meaning to dip my toe in to this library and joined some discussions but realized I wasn't following, and missed this before. There's a lot happening in this PR which makes it a bit difficult to review. What do you think about picking out little pieces into new PRs and trying to get them merged? I don't have merge access (though @transitive-bullshit started a convo about that #104 (comment)). However I'd be happy to review and 👍 pieces of this, and I think it would expedite this update. |
Agreed this is a good idea. When I use |
👍 |
], | ||
"dependencies": { | ||
"prop-types": "^15.6.2" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move this up before peerDependencies
so it's more noticeable?
This makes sense to me. |
Yeah, I realized there's too much happening when I submitted the pull request, but I was quite fed up with these "chores" so I didn't split it up. I'll move a few things from my "change log" in my initial comments to notes for a start. Al least it's good to see you agree with most of the changes though. Do you have any idea why the CI tests are failing? I'm not really willing to continue working on this if I don't know what I'm doing wrong there. Does everything work fine with you? Please let me know. |
Thanks @cdfa. I finally got around to updating CRL and releasing |
Fixes #120, #119 and #77
Changes:
react-dom
dependency from library (still used in example). It doesn't look like this is actually used..babel.rc
Notes
generateBundle
instead ofonwrite
egoist/rollup-plugin-postcss#148rollup-plugin-peer-deps-external
doesn't seem to matter. Issue