Skip to content

Fix error message when no private key is provided #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix error message when no private key is provided #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
68a819b
Fix error message when no private key is provided
seveas Oct 22, 2021
b5de5ba
Update the fixed PrivateKeyPath error message in the test
seveas Nov 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ func newClient(config ClientConfiguration) (*client, error) {

// check if token or private key is set
if len(config.Token) == 0 && config.PrivateKeyReader == nil {
return &client{}, errors.New("PrivateKeyReader, token or PrivateKeyReader is required")
return &client{}, errors.New("PrivateKeyPath, token or PrivateKeyReader is required")
}

if config.PrivateKeyReader != nil {
Expand Down
2 changes: 1 addition & 1 deletion client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ func TestNewClient(t *testing.T) {
// ClientConfig with only AccountName set should raise error about private keys
_, err = NewClient(cc)
if assert.Errorf(t, err, "expecting private key, token required error") {
assert.EqualError(t, err, "PrivateKeyReader, token or PrivateKeyReader is required")
assert.EqualError(t, err, "PrivateKeyPath, token or PrivateKeyReader is required")
}

cc.PrivateKeyReader = iotest.TimeoutReader(bytes.NewReader([]byte{0, 1}))
Expand Down