Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix mkdir if the dir already exists #2

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

GreatWizard
Copy link
Contributor

@GreatWizard GreatWizard commented Mar 11, 2023

Add parents option on the mkdir command to avoid issue if someone use the action twice in the same github action.

Extract from the mkdir man:

  -p, --parents
         no error if existing, make parent directories as needed

For the record, I got the issue here: https://github.com/GreatWizard/lan-play-status/actions/runs/4393468175/jobs/7693881509

@tyiu
Copy link

tyiu commented Mar 13, 2023

I ran into the same issue. I do a push to Transifex, then a pull from Transifex. The pull has this problem.

@GreatWizard
Copy link
Contributor Author

ping @codegaze and @kbairak for review

@kbairak
Copy link
Member

kbairak commented Mar 14, 2023

Good catch @GreatWizard . Thanks!

@kbairak kbairak merged commit 4a6ae32 into transifex:master Mar 14, 2023
@GreatWizard GreatWizard deleted the fix/mkdir branch September 25, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants