fix: compute 'new' model badge using parsed dates #1153
+67
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the
"new"badge logic in the model gallery endpoints by comparing real dates instead of doing string comparisons on"added".Problem
/model/galleryand/model/model_groups_listpreviously computed"new"usingmodel["added"] > cutoffwhere both values were strings (e.g."2024-12-01"). This is fragile and can produce incorrect results depending on formatting (and it’s explicitly marked with a TODO in the code).Changes
"added"into adatetime.datesafely (with fallback when missing/invalid)."new"using date comparison.Endpoints affected
GET /model/galleryGET /model/model_groups_listTesting
Added/updated pytest coverage in api/test/api/test_model.py.