Bump Envoy API to 1.18 #6
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Next: see if pulling in upstream updater script "just works". Also if using buf to generate java api is simpler?
The files now contain minimal diffs vs upstream, and as we bump Envoy API further, those diffs will further diminish. So it is easy to follow upstream. Tried, this actually generates compilable protos.
protoc version now matches egads's. Not that it has to, but why not.
Also ran update-api, but no API changes between 1.18.4 -> 1.18.6, unsurprizingly. Having this script from upstream around will make updates easier (it was a relatively recent addition in upstream).
StupidScience
approved these changes
Nov 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Used the 1.18.6 tip-of-minor patch version, see README.
Updated the scripts to be more in line with upstream.
Checklist