Skip to content

Fix balance statement URL and missing return (python) #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix balance statement URL and missing return (python) #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions sca-personal-tokens/get-statements-sca.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ def get_statement(one_time_token, signature):
'intervalEnd': interval_end})

url = (
base_url + '/v3/profiles/' + profile_id + '/borderless-accounts/'
base_url + '/v1/profiles/' + profile_id + '/balance-statements/'
+ account_id + '/statement.json?' + params)

headers = {
Expand All @@ -52,13 +52,13 @@ def get_statement(one_time_token, signature):
r = http.request('GET', url, headers=headers, retries=False)

print('status:', r.status)

if r.status == 200 or r.status == 201:
return json.loads(r.data)
elif r.status == 403 and r.getheader('x-2fa-approval') is not None:
one_time_token = r.getheader('x-2fa-approval')
signature = do_sca_challenge(one_time_token)
get_statement(one_time_token, signature)
return get_statement(one_time_token, signature)
else:
print('failed: ', r.status)
print(r.data)
Expand All @@ -73,14 +73,14 @@ def do_sca_challenge(one_time_token):

private_key = rsa.PrivateKey.load_pkcs1(private_key_data, 'PEM')

# Use the private key to sign the one-time-token that was returned
# Use the private key to sign the one-time-token that was returned
# in the x-2fa-approval header of the HTTP 403.
signed_token = rsa.sign(
one_time_token.encode('ascii'),
private_key,
one_time_token.encode('ascii'),
private_key,
'SHA-256')

# Encode the signed message as friendly base64 format for HTTP
# Encode the signed message as friendly base64 format for HTTP
# headers.
signature = base64.b64encode(signed_token).decode('ascii')

Expand All @@ -95,7 +95,7 @@ def main():
print('something is wrong')
print(statement)
sys.exit(0)

if 'transactions' in statement:
txns = len(statement['transactions'])
else:
Expand All @@ -105,4 +105,4 @@ def main():
print('\n', currency, 'statement received with', txns, 'transactions.')

if __name__ == '__main__':
main()
main()