Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I-12947 node canvas #3

Merged
merged 12 commits into from
May 30, 2024
Merged

I-12947 node canvas #3

merged 12 commits into from
May 30, 2024

Conversation

cameroncaci
Copy link

@cameroncaci cameroncaci commented May 29, 2024

I-12947

Changes proposed in this pull request:

yarn install will fail to properly build canvas with node-sass present, see snippet below. By replacing with Dart sass, yarn installs just fine again.

image

Relevant Articles
node canvas issue

PDFJS worker disable ability removed in newer update

Warning

It is likely this might not function as intended as the JavaScript errors will not appear until runtime. JavaScript is pretty lenient when compiling, I adjusted src/components/drivers/pdf-viewer.jsx to use the correct import but we'll only know if it works at runtime or testing

Note

With this PR, canvas is now present and compiles properly. Once released it should resolve the mymove issue. As for how it could break things, currently mymove can't even use the latest react file viewer release because of that missing module, so it'd be hard to cause more harm when it currently isn't working. I'm hoping if we push out a new release then mymove can pull it in, and then run our e2e tests which will verify successful or unsuccessful operation

@cameroncaci cameroncaci added enhancement New feature or request dependencies Pull requests that update a dependency file labels May 29, 2024
@cameroncaci cameroncaci self-assigned this May 29, 2024
@cameroncaci cameroncaci requested a review from deandreJones May 29, 2024 19:25
@cameroncaci
Copy link
Author

Ready for review

@cameroncaci cameroncaci merged commit 3075ee1 into main May 30, 2024
3 checks passed
@cameroncaci cameroncaci mentioned this pull request May 31, 2024
cameroncaci added a commit that referenced this pull request May 31, 2024
This reverts commit 3075ee1, reversing
changes made to 2a443ae.
cameroncaci added a commit that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

3 participants