B-21049 #11
Merged
B-21049 #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of just logging image errors in photo-viewer-wrapper.
and call onError if it was provided.
like it did before adding the catch.
keep dist/index.js from main
also remove the progress test which was removed in main, and update yarn.lock.
Conflicts: package.json keep v1.3.0
stevengleason-caci
requested review from
cameroncaci,
brianmanley-caci,
elizabeth-perkins,
samaysofo,
msaki-caci and
ryan-mchugh
|
There is no integrationTest branch in this repo, so this goes directly into main. The release to myMove is controlled by specifying a tag in the myMove package.json. The update to using v1.2.5 will be reviewed and tested in myMove's B-21049 branch. The v1.2.5 tag is on a branch without the latest v1.3.0 changes from main because those 1.3.0 changes aren't yet ready to go to myMove. |
ryan-mchugh
approved these changes
Oct 24, 2024
samaysofo
approved these changes
Oct 24, 2024
msaki-caci
approved these changes
Oct 24, 2024
and add the new generated dist/ files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If onError is provided, use it for errors in pdf-viewer and photo-viewer-wrapper.
See also tag #v1.2.5 for these changes without the 1.3.0 merge from main.