Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix html loader for dev webpack #10

Closed
wants to merge 1 commit into from
Closed

fix html loader for dev webpack #10

wants to merge 1 commit into from

Conversation

cameroncaci
Copy link

Summary

Resolves the following error when serving dev. No version bump needed, this is for dev.

ERROR in   Error: The loader didn't return html.

  - index.js:323 HtmlWebpackPlugin.evaluateCompilationResult
    [react-file-viewer]/[html-webpack-plugin]/index.js:323:24

  - index.js:230
    [react-file-viewer]/[html-webpack-plugin]/index.js:230:22

  - task_queues:95 process.processTicksAndRejections
    node:internal/process/task_queues:95:5

  - async Promise.all

  - async Promise.all

How to test

  1. Clone locally
  2. yarn install
  3. yarn serve:dev
  4. Verify http://localhost:8081/ loads a PDF

@cameroncaci cameroncaci requested a review from a team October 22, 2024 18:43
@cameroncaci cameroncaci self-assigned this Oct 22, 2024
@cameroncaci
Copy link
Author

#12 inherits these changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deandreJones deandreJones Awaiting requested review from deandreJones deandreJones was automatically assigned from transcom/mountain-movers

@danieljordan-caci danieljordan-caci Awaiting requested review from danieljordan-caci danieljordan-caci was automatically assigned from transcom/mountain-movers

@TevinAdams TevinAdams Awaiting requested review from TevinAdams TevinAdams was automatically assigned from transcom/mountain-movers

@traskowskycaci traskowskycaci Awaiting requested review from traskowskycaci traskowskycaci was automatically assigned from transcom/mountain-movers

Assignees

@cameroncaci cameroncaci

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cameroncaci