Skip to content

Commit

Permalink
Force plug-in activation for custom property testers
Browse files Browse the repository at this point in the history
This change ensures Eclipse correctly uses the property testers
'isBashFileWithoutExtension' and 'isOpenPathActionEnabled', by setting
the 'forcePluginActivation' property in the respective plugin.xml
entries. This allows Eclipse to load the property tester class prior to
trying to use it - in case the bash editor plug-in was not activated
yet.

Fixes: de-jcup#275
Signed-off-by: Simeon Andreev <simeon.danailov.andreev@gmail.com>
  • Loading branch information
trancexpress committed Jan 16, 2024
1 parent 0e28287 commit 4b3b6eb
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions basheditor-plugin/plugin.xml
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@
<count value="1"/>
<iterate ifEmpty="false">
<adapt type="org.eclipse.core.resources.IFile">
<test property="de.jcup.basheditor.isBashFileWithoutExtension" value="true"/>
<test property="de.jcup.basheditor.isBashFileWithoutExtension" value="true" forcePluginActivation="true"/>
</adapt>
</iterate>
</with>
Expand All @@ -138,7 +138,7 @@
<iterate ifEmpty="false">
<adapt type="org.eclipse.core.resources.IFile">
<or>
<test property="de.jcup.basheditor.isBashFileWithoutExtension" value="true"/>
<test property="de.jcup.basheditor.isBashFileWithoutExtension" value="true" forcePluginActivation="true"/>
<test property="org.eclipse.core.resources.extension" value="sh" />
</or>
</adapt>
Expand All @@ -160,7 +160,7 @@
<count value="1"/>
<iterate ifEmpty="false">
<adapt type="org.eclipse.core.resources.IResource">
<test property="de.jcup.basheditor.isOpenPathActionEnabled" value="true"/>
<test property="de.jcup.basheditor.isOpenPathActionEnabled" value="true" forcePluginActivation="true"/>
</adapt>
</iterate>
</with>
Expand Down Expand Up @@ -890,7 +890,7 @@ fi</pattern>
value="*.sh"/>
</adapt>
<adapt type="org.eclipse.core.resources.IFile">
<test property="de.jcup.basheditor.isBashFileWithoutExtension" value="true"/>
<test property="de.jcup.basheditor.isBashFileWithoutExtension" value="true" forcePluginActivation="true"/>
</adapt>
</or>
</iterate>
Expand Down

0 comments on commit 4b3b6eb

Please sign in to comment.