Refactor discord Rpc to be more readable and require less mut
#427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and some documentation
reduces the nesting and should be more reasonable
instead of trying to recieve, then waiting 1 second.
…eed it sending over a channel does not require "mut self"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This function refactors
discord::Rpcand touching code to be less nested, more documented and dont requiremut selfwhere not necessary anymore.Additionally, the
try_recvhas been changed to justrecvas we dont need to check or update anything other than that channel in that thread.Also includes some slight style changes regarding
playback::playlistand also moves the playlist stop procedure to a dedicated function.PS: for lint CI failures, see #426